ASP.Net (VB) - stored procedure not firing? **Resolved**

[simmo]

Ok, I've a bit of code that runs and feeds data from an xml file into a database table. In the process of doing that, I run a stored proc that will delete old data fed in on previous runs... but the data is not being deleted...

I know it is not the sproc itself, because I can run that via the query analyzer and records are deleted.

I know the code (posted below) is firing because I get "success" in my gErrorMsg that I am setting.

Is there something stupid I am not seeing, like I'm not executing the sproc, or something?  

Code:

   Private Function dropLSItems(ByVal fSellerId As Integer) As Boolean
        Dim sqlConn2 As New SqlConnection(System.Configuration.ConfigurationManager.ConnectionStrings("constring").ToString())
        Dim cmd2 As SqlCommand = sqlConn2.CreateCommand
        cmd2.CommandType = CommandType.StoredProcedure

        cmd2.CommandText = "uspDeleteLsItems_BySellerId"
        cmd2.Parameters.AddWithValue("@SellerId", fSellerId)

        Using (sqlConn2)
            Try
                sqlConn2.Open()
                cmd2.ExecuteNonQuery()
                gErrorMsg = gErrorMsg & vbCrLf & "<br>dropLSItems sucess: [sellerid:" & gSellerId & "] " & vbCrLf & "<br>last sql:uspDeleteLsItems_BySellerId"
                Return True
            Catch ex As Exception
                gErrorMsg = gErrorMsg & vbCrLf & "<br>dropLSItems fail: [sellerid:" & gSellerId & "] " & ex.Message & vbCrLf & "<br>last sql:uspDeleteLsItems_BySellerId"
                HttpContext.Current.Response.Write("dropLSItems: " & ex.Message & "<br>")
                Return False
            End Try
        End Using

    End Function

[Jason Reed]

I'm pretty doubtful that this is the problem, but it looks like in your gErrorMsg line that you are using a variable that is not declared before. The gSellerId which probably has nothing to do with why the sproc is working or not.

[simmo]

those are globals (i preface them with g) so they are defined at the start of the class.

however! I need to change that to be the id that the function is passing in, just to be sure it is correct, you may have found it (I've modified the code, but won't know till tomorrows run takes forever to debug like this)

[simmo]

That was it! It wasn't deleting anything because I was passing in the wrong Id 


thanks 

[Jason Reed]

Thus another reason why Global Variables are bad juju.

[simmo]

yeah, vbscript taught me a lot of bad habits that .net is getting me out of. I LOVE block level variables now, so when I have to write vbscript, I put everything is sub routines. With that app, I have two id's for each "seller" one for my database, and one for a 3rd party database... I had mine (correct one) in the global, but theirs (wrong one) was being passed in.